Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issues Related to Asset Library #919

Merged
merged 18 commits into from
Sep 29, 2024
Merged

Fix Issues Related to Asset Library #919

merged 18 commits into from
Sep 29, 2024

Conversation

Gerrnperl
Copy link

This PR addresses several issues related to asset library

Fixes:

  1. Excessively long asset name causes the asset item to be the wrong size

    • Limited the width of the asset item in the asset library.
    • Added ellipsis to the asset name if it is too long.

  2. Repeatedly adding assets to a project results in an error on the backend

    • Implemented a check to verify if the asset is already in the database before adding it.

  3. Missing search suggestions for old assets

    • Added a script to load assets into the Milvus database.

  4. Duplicate asset item in Milvus database

    • Implemented a check to verify if the user asset exists before adding it.

  5. Wrong temporarily calculated asset rate

    • Fixed the calculation logic for the temporary asset rate.

@Gerrnperl
fix: limit the width of the asset item
3869859 
- limit the width of the asset item in the asset library
- ellipsis the asset name if it is too long
@Gerrnperl
feat: check if the asset is already in the database before adding it
4ee6270
@Gerrnperl
feat: add a script to load assets to Milvus database
ce723ea
@Gerrnperl
feat: check if user asset exists before adding it
ffe09ec 
Added a check logic before adding an asset to the database to avoid
adding the same asset multiple times and causing duplication errors.

If the asset already exists in the database,
the add operation is not performed.
@Gerrnperl
format code
77b7dc2
@Gerrnperl
fix: temporarily calculated rate
5bc9f03
@Gerrnperl
fix width of AI AssetItem
d77a53f
@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Sep 18, 2024

Hi @Gerrnperl. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiniu-x qiniu-x
Copy link

qiniu-x bot commented Sep 19, 2024

[Git-flow] Hi @Gerrnperl, There are some suggestions for your information:

Rebase suggestions

  • Following commits have duplicated messages

    format code

    format code

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@Gerrnperl
feat: add animation loading status after animation generated
96fdb80 
Shows a loading animation after the animation is generated and before it is uploaded and displayed.
Shows a tip to let users start motion recording to generate animation.
@Gerrnperl Gerrnperl marked this pull request as ready for review September 20, 2024 10:30
@Gerrnperl Gerrnperl changed the title [WIP] Fix Issues Related to Asset Library Fix Issues Related to Asset Library Sep 20, 2024
@Gerrnperl Gerrnperl marked this pull request as draft September 21, 2024 08:30
@Gerrnperl Gerrnperl marked this pull request as ready for review September 21, 2024 08:33
@JiepengTan JiepengTan merged commit f69d0c9 into goplus:trailhead_res Sep 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gerrnperl @JiepengTan